Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Lifecycle Release Bundle Distribute #797

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Support Lifecycle Release Bundle Distribute #797

merged 4 commits into from
Aug 30, 2023

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Jul 12, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Breaking Changes:
A few changes to the Distribution Release Bundle V1 service manager.

@RobiNino RobiNino added safe to test Approve running integration tests on a pull request breaking change Automatically generated release notes new feature Automatically generated release notes labels Jul 12, 2023
@RobiNino RobiNino requested review from eyalbe4 and yahavi July 12, 2023 08:09
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 12, 2023
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Jul 12, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 12, 2023
@RobiNino RobiNino marked this pull request as ready for review July 12, 2023 08:45
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jul 24, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jul 24, 2023
yahavi
yahavi requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Please see my inline comments.

I also noticed that there aren't integration tests for the Lifecycle service.
Please consider adding such tests in this or another PR.

distribution/manager.go Show resolved Hide resolved
utils/distribution/specutils.go Show resolved Hide resolved
lifecycle/services/distribute.go Outdated Show resolved Hide resolved
lifecycle/services/distribute.go Outdated Show resolved Hide resolved
distribution/services/utils/releasebundlebody.go Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 removed their request for review July 25, 2023 09:25
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Aug 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 27, 2023
@RobiNino RobiNino mentioned this pull request Aug 27, 2023
Merged
4 tasks
@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@RobiNino RobiNino merged commit df2d2a8 into jfrog:dev Aug 30, 2023
15 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

Assignees
No one assigned
Labels
breaking change Automatically generated release notes new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @yahavi